[API Compat] Add attribute diffing for generic and regular parameters#7058
Merged
safern merged 2 commits intodotnet:mainfrom Mar 10, 2021
Merged
[API Compat] Add attribute diffing for generic and regular parameters#7058safern merged 2 commits intodotnet:mainfrom
safern merged 2 commits intodotnet:mainfrom
Conversation
safern
changed the title
eerhardt
reviewed
Mar 8, 2021
src/Microsoft.DotNet.ApiCompat/src/Rules/Compat/AttributeDifference.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 8, 2021
src/Microsoft.DotNet.ApiCompat/src/Rules/Compat/AttributeDifference.cs
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Mar 9, 2021
Member
|
Can you try this in dotnet/runtime to make sure it’s not finding anything unexpected before merging? If possible have a PR with any necessary baselines ready. |
Member
Author
Yeah, that is exactly what I'm working on now. Will not merge this until I get a hold of all the issues and will put up a PR to dotnet/runtime to fix them. |
ericstj
reviewed
Mar 9, 2021
Member
Author
|
@missymessa FYI: this will break dotnet/runtime in case you see it in the validation builds. I have a PR in dotnet runtime: dotnet/runtime#49408 which should fix it. Once I've got a build out for this I will include updating this package on my PR to unblock arcade consumption there. |
lukas-lansky
added a commit
that referenced
this pull request
Mar 23, 2021
* [master] Update dependencies from dotnet/xliff-tasks mono/linker (#7048) [master] Update dependencies from dotnet/xliff-tasks mono/linker * Post build sign algorithmic description (#7042) * Post build sign algorithmic description * Update Documentation/CorePackages/PostBuildSigning.md Co-authored-by: Christopher Costa <chcosta@microsoft.com> * Update Documentation/CorePackages/PostBuildSigning.md Co-authored-by: Christopher Costa <chcosta@microsoft.com> * Update Documentation/CorePackages/PostBuildSigning.md Co-authored-by: Christopher Costa <chcosta@microsoft.com> Co-authored-by: Christopher Costa <chcosta@microsoft.com> * Preview flow setup script (#6996) This script sets up flow for a .NET 6 preview given a few input parameters. * Revert "Saving sdk.txt using utf8" (#7051) This reverts commit 5624102. * Update dependencies from https://github.com/mono/linker build 20210304.2 (#7055) [master] Update dependencies from mono/linker * [master] Update dependencies from dotnet/roslyn dotnet/xharness (#7061) [master] Update dependencies from dotnet/roslyn dotnet/xharness * Add pipeline triggers for main branch (#7067) * remove triggers for master (#7069) * use main as the publishing branch (#7070) * Update dependencies from https://github.com/dotnet/arcade build 20210305.1 (#7072) [main] Update dependencies from dotnet/arcade * Add GetCompatibilePackageTargetFrameworks Task to the new packageValidation package (#7057) * add package valiation proj * adding tests * address feedback * delete extra file * correct typo * set XUnitPublishTargetFramework to net5.0 * use netcoreapp3.1 * Add 'checkDownloadedFiles: true' to all invocations of DownloadBuildArtifacts (#7066) * Use blob.core.windows instead of azureedge for Helix SDK / CLI acquisition (#7078) Since Helix agents tend to be in the same data center or geolocated in the Western US, this isn't a perf degradation (gain, in some cases) but also when executed at Helix scale, means a substantial savings * Add handling for new queues (#7079) * Send `System.PullRequest.TargetBranch` in job created by SendHelixJob task (#7075) * [API Compat] Add attribute diffing for generic and regular parameters (#7058) * Add attribute diffing for generic and regular parameters * PR Feedback (avoid duplication) * Mark internal channel configs as internal (#7090) * Update arcade for publishing fixes (#7093) * fix parameter name (#7094) * Update SDK's version to 6.0 Preview 2 (#7096) * [main] Update dependencies from dotnet/arcade mono/linker (#7081) [main] Update dependencies from dotnet/arcade mono/linker - Merge branch 'main' into darc-main-c7daeaa9-149a-434b-8e58-adbd726d8077 * Improve the M2M guide (#7091) * Use ubuntu & debian instead of unix & freebsd (#7089) * use ubuntu & debian instead of unix & freebsd * use linux instead of ubuntu * Avoid zipping VS templates (#7056) * Some meta data was dropping, so I included it so it wouldn't get dropped anymore (#7100) * Some meta data was dropping, so I included it so it wouldn't get dropped anymore * remove added whitespace * using tryGetValue to validate existence of data instead of containsKey * Documentation update for changes to Arcade Validation (#7063) * Documentation update for changes to Arcade Validation * Update documentation to use best judgement about validating against bellwether repos * Update Documentation/Validation/Overview.md Co-authored-by: Ricardo Arenas <riarenas@microsoft.com> * Update Documentation/Validation/Overview.md Co-authored-by: Ricardo Arenas <riarenas@microsoft.com> * Update Documentation/Validation/Overview.md Co-authored-by: Ricardo Arenas <riarenas@microsoft.com> * Tweaks per code review feedback Co-authored-by: Ricardo Arenas <riarenas@microsoft.com> * Add "call" to prevent the wrapper script from causing exit before AzDO reporter execution. (#7103) * Fix argument escaping when running Command (#7109) I found out the on Linux, commands were failing because every single one of them was escaped, so things like this would fail: ``` dotnet "tool" "install" "--version" ... ``` I need this change for #7029 * re-enable component governance (#7105) * [main] Update dependencies from dotnet/roslyn dotnet/xharness dotnet/arcade mono/linker (#7098) [main] Update dependencies from dotnet/roslyn dotnet/xharness dotnet/arcade mono/linker * Update badge branch names (#7112) * Add OneLocBuild template to arcade (#6977) * M2M Renaming Guide - Search for master not main (#7026) * Enable conditional facts/theories to reference static fields (#7117) * Add net472 to PackageValidation package (#7115) * add net472 to package * correcting the csproj * add net472 to tests * Add binaryLog option to SB Build command (#7104) * [main] Update dependencies from dotnet/arcade mono/linker (#7116) [main] Update dependencies from dotnet/arcade mono/linker * Add support for Mono AOT perf runs (#7123) * [main] Update dependencies from dotnet/arcade mono/linker (#7124) [main] Update dependencies from dotnet/arcade mono/linker * Add telemetry to generate-locproject.ps1 (#7122) * Update master -> main for perf scripts (#7127) * [main] Update dependencies from dotnet/xliff-tasks mono/linker (#7129) [main] Update dependencies from dotnet/xliff-tasks mono/linker * Fix the public key token in frameworkList (#7130) I happened to be referencing this code and noticed it dropped leading 0s from bytes when formatting the public key token. For example `b03f5f7f11d5a3a` `b03f5f7f11d50a3a` * [main] Update dependencies from dotnet/xliff-tasks mono/linker dotnet/xharness (#7131) * Update dependencies from https://github.com/dotnet/xliff-tasks build 20210319.2 XliffTasks From Version 1.0.0-beta.21168.1 -> To Version 1.0.0-beta.21169.2 * Update dependencies from https://github.com/mono/linker build 20210319.4 Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.2.21169.1 -> To Version 6.0.100-preview.2.21169.4 * Update dependencies from https://github.com/dotnet/xharness build 20210319.2 Microsoft.DotNet.XHarness.CLI From Version 1.0.0-prerelease.21162.1 -> To Version 1.0.0-prerelease.21169.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Add .NET 6 previews 3-5 (#7126) * Add .NET 6 previews 3-5 * Add VS 17.0 * Update OneLocBuild stuff for AzDO repos (#7136) Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Matt Mitchell <mmitche@microsoft.com> Co-authored-by: Christopher Costa <chcosta@microsoft.com> Co-authored-by: Ricardo Arenas <riarenas@microsoft.com> Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com> Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com> Co-authored-by: Drew Scoggins <anscoggi@microsoft.com> Co-authored-by: Łukasz Patalas <lupatala@microsoft.com> Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Co-authored-by: Bill Wert <billwert@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com> Co-authored-by: Tomáš Matoušek <tmat@users.noreply.github.com> Co-authored-by: Missy Messa <47990216+missymessa@users.noreply.github.com> Co-authored-by: Epsitha Ananth <47157394+epananth@users.noreply.github.com> Co-authored-by: Jon Fortescue <jofortes@microsoft.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Michael Simons <msimons@microsoft.com> Co-authored-by: Eric StJohn <ericstj@microsoft.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
…dotnet#7058) * Add attribute diffing for generic and regular parameters * PR Feedback (avoid duplication)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We decided before that we were going to do this on the new APICompat, however @eerhardt is having a hard time to fix the linker warnings in dotnet/runtime because of this limitation and since it was a simple change I tackled it to unblock him.
Fixes: #5925